Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore oracle test #36140

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Ignore oracle test #36140

merged 2 commits into from
Sep 25, 2023

Conversation

brunobat
Copy link
Contributor

No description provided.

@brunobat brunobat requested review from yrodiere and geoand September 25, 2023 14:41
yrodiere
yrodiere reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense but you might want to add a link to relevant information + create an issue to eventually revert this.

@brunobat brunobat mentioned this pull request Sep 25, 2023
Closed
@michalvavrik
Copy link
Member

Hey, did you report this here https://github.com/gvenzl/oci-oracle-xe/issues, can you link exact upstream issue or provide any context on what "buggy" means? I read but this PR and #36141 and thre is really no context on what it means. Maybe the issue you opened could provide error message etc. I am also experiencing issues with Oracle and I'd expect this is much larger problem than failing OpenTelemetry JDBC instrumentation tests. Are you planning to open upstream issue, please?

@michalvavrik
Copy link
Member

@brunobat I just read the issue you opened, we have same problem, "good". Thanks for opening it.

@brunobat
Copy link
Contributor Author

done here: gvenzl/oci-oracle-xe#227
No worries, @michalvavrik

@quarkus-bot

This comment has been minimized.

Sign in to view
@brunobat
Copy link
Contributor Author

Moving to a real computer with linux.

@brunobat
Copy link
Contributor Author

Removed the tests, will bring them back once the image is fixed

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 25, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit 6b1f33e into quarkusio:main Sep 25, 2023
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 25, 2023
@brunobat brunobat deleted the oracle-test branch October 17, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere left review comments

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@brunobat @michalvavrik @yrodiere @geoand